[Bug 1647147] Review Request: pmdk-convert - Conversion tool for PMDK pools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1647147



--- Comment #3 from Dan Williams <dan.j.williams@xxxxxxxxx> ---
So the header file warnings are a false positive they'll trigger on any
debugsource package.

The only concern I have is why are the following:

pmdk-convert: /usr/lib64/pmdk-convert/libpmem-convert.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v1.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v2.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v3.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v4.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v5.so

...globally installed libraries? It seems they are just potentially dynamic
objects for the pmdk-convert utility, but do they have any usage for any other
application. If they are just private why not build them into the binary? If
they are public and intended to be consumed by other applications then they
should be versioned and moved to their own pmdk-convert-libs sub-pacakge.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux