https://bugzilla.redhat.com/show_bug.cgi?id=1649577 --- Comment #12 from Jie Kang <jkang@xxxxxxxxxx> --- Following the sample [1], please include a .sh script in the srpm that users can run without modification to acquire the sources. The comments in the spec [2] aren't useful as users can't copy-paste and run them without a large amount of modification to acquire the source. [1] https://src.fedoraproject.org/rpms/objectweb-asm/blob/master/f/objectweb-asm.spec#_12 [2] # original source: http://hg.openjdk.java.net/%%{name}/%%{name}/archive/%%{hgrevhash}.tar.gz # wget http://hg.openjdk.java.net/%%{name}/%%{name}/archive/%%{hgrevhash}.tar.gz # tar xzf %%{hgrevhash}.tar.gz # rm %%{hgrevhash}.tar.gz # cp -r %%{name}-%%{hgrevhash}/core/ %%{name}-%%{version}/ # cp %%{name}-%%{hgrevhash}/license/* %%{name}-%%{version}/ # cp %%{name}-%%{hgrevhash}/README.md %%{name}-%%{version}/ # tar czf %%{name}-%%{version}.tar.gz %%{name}-%%{version}/ # rm -r %%{name}-%%{version}/ %%{name}-%%{hgrevhash} Source0: %{name}-%{version}.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
