Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: inchi - The IUPAC International Chemical Identifier library https://bugzilla.redhat.com/show_bug.cgi?id=249212 wtogami@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From wtogami@xxxxxxxxxx 2007-09-19 19:16 EST ------- Excellent, the licensing is FAR less confusing and explicit now. Possibly a few more issues to deal with before approval: [builder1@newcaprica x86_64]$ rpmlint inchi-1.0.2-0.1.fc8.x86_64.rpm inchi.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/inchi-1.0.2/LICENSE inchi.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/inchi-1.0.2/readme.txt inchi.x86_64: W: dangling-relative-symlink /usr/lib64/libinchi.so.1 libinchi.so.1.01.00 inchi.x86_64: W: invalid-license LGPL inchi.x86_64: E: invalid-ldconfig-symlink /usr/lib64/libinchi.so.1.02.00 libinchi.so.1.01.00 http://fedoraproject.org/wiki/Licensing The invalid-license warning is a must fix. Please refer to the licensing guidelines to use a label that is more specific to the LGPL license and version. The symlink warning and errors are possibly suspect, please look into that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review