https://bugzilla.redhat.com/show_bug.cgi?id=1652588 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Several tips: you can use the %pypi_source macro: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi you SHOULD use the %python_provide macro: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro you can try to use the automatic runtime depepndiencies: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies you SHOULD make the tests run: + /usr/bin/python3 setup.py test running test running egg_info writing pytest_metadata.egg-info/PKG-INFO writing dependency_links to pytest_metadata.egg-info/dependency_links.txt writing entry points to pytest_metadata.egg-info/entry_points.txt writing requirements to pytest_metadata.egg-info/requires.txt writing top-level names to pytest_metadata.egg-info/top_level.txt reading manifest file 'pytest_metadata.egg-info/SOURCES.txt' writing manifest file 'pytest_metadata.egg-info/SOURCES.txt' running build_ext ---------------------------------------------------------------------- Ran 0 tests in 0.000s OK or, if you decide not to, you MUST NOT create false assumptions that the tests are run (I'm in contact with Petr about sponsoring.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx