https://bugzilla.redhat.com/show_bug.cgi?id=1652712 --- Comment #2 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- Thanks for taking a look! > # Makes *.cmxs executable such that they will be stripped. Aha. Indeed, that fixes it. :) > - License is wrong, it is LGPLv2+ not BSD. Oops... my bad. Fixed. > - No need to reinclude the license here as the devel subpackage depends on the main package Fixed. > - Patch these with the new FSF address in %prep, and send the patch upstream: Fixed. I"m not sure upstream will care (since this is "deprecated", as I mentioned)-- but I can at least send it to them. Spec URL: https://tc01.fedorapeople.org/ocaml/lwt/ocaml-lwt-log.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/lwt/ocaml-lwt-log-1.1.0-2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx