[Bug 1652036] Review Request: cockpit-session-recording - Package provides session recording playback in Cockpit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1652036

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - You missing a URL field:

URL:            https://github.com/Scribery/cockpit-session-recording

 - There doesn't seem to be a release upstream, either ask upstream to tag a
release or package a dev snapshot:

%global commit          2162092977dd3882834e2e13ee6e80e8e7fd66b4
%global shortcommit     %(c=%{commit}; echo ${c:0:7})
%global snapshotdate    20181122

 - Source0 must be a URL pointing to the archive

Source0:        %url/archive/%{commit}/%{name}-%{shortcommit}.tar.gz

%prep
%autosetup -n %{name}-%{commit}

 - changelog must contain your entry

 - Not needed for a noarch package:

%define debug_package %{nil}

 - Summary/Description must be more detailed than that

 - Be more specific here:

 %{_datadir}/cockpit/session-recording
 %{_datadir}/metainfo/org.cockpit-project.session-recording.metainfo.xml

 - Validate the Appdata file
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux