https://bugzilla.redhat.com/show_bug.cgi?id=1650987 --- Comment #5 from Alain V. <alain.vigne.14@xxxxxxxxx> --- Thanks a lot Fabio for this detailed feed-back. I will use your numbering to answer. 1) Originally, I named it genht.spec, and developed the spec file as you suggested (it was easier :). But when I submitted to the main developer, he said Debian was already packaging the lib as "libgenht1", under https://packages.debian.org/sid/amd64/libgenht1 and he prefers the package name to be "libgenht". I have the genht.spec file. Who will have the last word ? 2a, 2b) I should investigate and implement your proposal... 2c) I create a .so symlink from the .spec file. The ln-s command is in between pushd/popd directives. 2d) Again, originally I did not have this -static subpackage. But the main developer wanted to distribute the archive lib. too. He plans to use this library for other applications. I think, by proper packaging the other applications, we can avoid this static lib. Correct ? 2e) The sole binary is a "trivial" example of how to use the lib. Not needed in the distro. I am used to work with the main developer. Never, ever he would accept meson, because it is Python. He is C89 to the bare. 3) You suggest to use the "genht" text iso a macro. For a "final" spec file (close to "approved" state), I agree. I think I will simplify that. About comments, I prefer to keep them, but did not realize this "section" subtle thing. I will simplify and move them around. 3a) You are right. Have to change that. 3b) Agree 3c) I have to implement your suggestion 3d) Will change the comment, as I think the name "libgenht" will be kept. 3e) %dir %{_includedir}/%{generic_name} is to own the directory, while %{_includedir}/%{generic_name}/* describes all the files in the dir. It seems not equivalent to me ? Thank you again for your time. As soon as I can, I will experiment those changes and update my COPR. I'll then post a comment here, linking to the new proposal. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
