https://bugzilla.redhat.com/show_bug.cgi?id=1649577 --- Comment #9 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> --- (In reply to Salman Siddiqui from comment #8) > There is a script that is used to produce the tarball (it downloads a > specific revision, NOT the tip): > https://pagure.io/jmc-rpm/blob/master/f/jmc-core/generate_jmc_core_tarball.sh > > Would it be better to include this script in the comments directly in the > spec file? Yes, a comment needs to be added to the spec file how to generated the source tarball. See this for example: https://src.fedoraproject.org/rpms/objectweb-asm/blob/master/f/objectweb-asm.spec#_12 The script should be included in the srpm. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx