https://bugzilla.redhat.com/show_bug.cgi?id=1647354 --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Vendor: is forbidden in Fedora - Not needed anymore: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig Use %ldconfig_scriptlets for F27 or EPEL. See https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets - Not needed, it is the default: %defattr(-,root,root,-) - You forgot %{?_isa} in the Requires for the devel subpackage: Requires: %{name}%{?_isa} = %{version}-%{release} - This part should be in %build: cd doc/wpg-src %__make cd ../wag-src # package pdftk was removed from distribution (in F21) replace it by qpdf command sed -i -e 's/pdftk/qpdf --empty wag.pdf --pages wag1.pdf wag2.pdf wag3.pdf wag4.pdf -- # /g' Makefile %__make cd ../wug-src %__make - Use make, not %__make. These kind of macros are not useful. - You could use pushd/popd instead of cd ../ in that section - GCC should be a BR rot a RR BuildRequires: gcc - Remove the glob here to own the include dir: %files devel %{_includedir}/%{name}/ %{_libdir}/libwfdb.so - Same here and own %{_datadir}/%{name} %dir %{_datadir}/%{name} %{_datadir}/%{name}/database/ %{_datadir}/%{name}/ps/ - Your build must respect Fedora's CCFLAGS and LDFLAGS - Build fails: DEBUG util.py:490: BUILDSTDERR: No matching package to install: 'rman' DEBUG util.py:490: BUILDSTDERR: Not all dependencies satisfied DEBUG util.py:490: BUILDSTDERR: Error: Some packages could not be found. I have no idea what rman is in this context. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
