[Bug 1648728] Review Request: python-progressbar2 - A Progressbar library to provide visual progress to long running operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1648728



--- Comment #14 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #13)
> Somebody should test euca2ools, libtaskotron and python-bitmath with
> progressbar2 installed in place of progressbar. If that works, things should
> be quite easy.

I ran some quick tests in a virtual environment.

--

I can't get libtaskotron's tests to run even with the original progressbar
module. I don't know how these tests are meant to be run. I get this with both.
Someone else will have to check that up:

running test
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/_pytest/config/__init__.py", line 372,
in _getconftestmodules
    return self._path2confmods[path]
KeyError: local('/home/asinha/dump/progressbar-test/libtaskotron/testing')

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/_pytest/config/__init__.py", line 403,
in _importconftest
    return self._conftestpath2mod[conftestpath]
KeyError:
local('/home/asinha/dump/progressbar-test/libtaskotron/testing/conftest.py')

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/_pytest/config/__init__.py", line 409,
in _importconftest
    mod = conftestpath.pyimport()
  File "/usr/lib/python3.7/site-packages/py/_path/local.py", line 668, in
pyimport
    __import__(modname)
  File "/usr/lib/python3.7/site-packages/_pytest/assertion/rewrite.py", line
226, in load_module
    py.builtin.exec_(co, mod.__dict__)
  File "/home/asinha/dump/progressbar-test/libtaskotron/testing/conftest.py",
line 13, in <module>
    import libtaskotron.config
  File
"/home/asinha/dump/progressbar-test/libtaskotron/libtaskotron/config.py", line
25, in <module>
    from libtaskotron import file_utils
  File
"/home/asinha/dump/progressbar-test/libtaskotron/libtaskotron/file_utils.py",
line 12, in <module>
    import progressbar
ModuleNotFoundError: No module named 'progressbar'
ERROR: could not load
/home/asinha/dump/progressbar-test/libtaskotron/testing/conftest.py


--

bitmath looks like it needs patching:

.. 
running build_ext
Traceback (most recent call last):
  File "setup.py", line 81, in <module>
    'bitmath = bitmath:cli_script',
  File
"/home/asinha/dump/progressbar2-virt/lib64/python3.7/site-packages/setuptools/__init__.py",
line 140, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib64/python3.7/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/lib64/python3.7/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/usr/lib64/python3.7/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File
"/home/asinha/dump/progressbar2-virt/lib64/python3.7/site-packages/setuptools/command/test.py",
line 228, in run
    self.run_tests()
  File
"/home/asinha/dump/progressbar2-virt/lib64/python3.7/site-packages/setuptools/command/test.py",
line 250, in run_tests
    exit=False,
  File "/usr/lib64/python3.7/unittest/main.py", line 100, in __init__
    self.parseArgs(argv)
  File "/usr/lib64/python3.7/unittest/main.py", line 124, in parseArgs
    self._do_discovery(argv[2:])
  File "/usr/lib64/python3.7/unittest/main.py", line 244, in _do_discovery
    self.createTests(from_discovery=True, Loader=Loader)
  File "/usr/lib64/python3.7/unittest/main.py", line 154, in createTests
    self.test = loader.discover(self.start, self.pattern, self.top)
  File "/usr/lib64/python3.7/unittest/loader.py", line 347, in discover
    tests = list(self._find_tests(start_dir, pattern))
  File "/usr/lib64/python3.7/unittest/loader.py", line 404, in _find_tests
    full_path, pattern, namespace)
  File "/usr/lib64/python3.7/unittest/loader.py", line 481, in _find_test_path
    tests = self.loadTestsFromModule(package, pattern=pattern)
  File
"/home/asinha/dump/progressbar2-virt/lib64/python3.7/site-packages/setuptools/command/test.py",
line 54, in loadTestsFromModule
    tests.append(self.loadTestsFromName(submodule))
  File "/usr/lib64/python3.7/unittest/loader.py", line 154, in
loadTestsFromName
    module = __import__(module_name)
  File "/home/asinha/dump/progressbar-test/bitmath/bitmath/integrations.py",
line 84, in <module>
    class BitmathFileTransferSpeed(progressbar.widgets.Widget):
AttributeError: module 'progressbar.widgets' has no attribute 'Widget'

...

euca2ools isn't py3 compatible from the looks of it? Will it be dropped in
rawhide then?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux