https://bugzilla.redhat.com/show_bug.cgi?id=1636019 --- Comment #13 from Petra Alice Mikova <pmikova@xxxxxxxxxx> --- Hi, following issues should be fixed: - license changed to GPLv3, fixed listing it in %license - now requires explicitly java 1.8.0, will add support for 11 later as this is not trivial to solve (and not time pressuring) - fixed agent configuration not to overwrite already created records - dropped explicit requires - changelog is now in correct format - fixed paths in json, now the URL is really URL (not misleading) - added links to the decompilers into gui as clickable button redirecting to the decompiler website - removed the compiler tools, as this is ubuntu distro specific - config file now contains path to the json file (config source) - the configuration is now uneditable, when you dont have the permissions to edit the json (e.g. system config) - the configuration is now correctly saved and if there are issues with the saving, an error dialog is raised - created and added desktop file - fixed the duplicated entry in files - fixed the group id to java-runtime-decompiler, my name would not be fair since I control the upstream, but there is other contributor to the project, who did a lot of job on the decompiler. - fixed the issues with overwriting changes in configuration - script seemed okay but did not work as expected, should be ok now Regarding the build in rawhide - it works for me locally - both srpm and rpms were sucesfully created and i was able to install them. Regarding the question: Is no-arch. Do it work on non-jit arches? - I don't any reason, why it should not, but I dont have the hardware to try it. If someone reports a bug on a specific arch, I either solve it, or restrict the architectures. Regarding the rpmlint - I have fixed everything I could except: The decompiler/decompilation etc. errors are unfixable - there are no typos, it just does not know the words. Devel dependency is justified - we need the tools.jar for correct run of the application and they are in devel. The .java configuration files are replacable by design - if we ever want to change the wrappers, they need to be replaced so the application can work, plus they should not be touched by users unless they really know what they are doing, and if yes, they can create their own wrapper or rename the current ones. If we change the .java files, it means, the old ones will no longer be compatible with the application anyways. New sources (built for rawhide, so I can prove it really works) Spec URL: https://raw.githubusercontent.com/pmikova/fedora-packaging-jrd/master/java-runtime-decompiler.spec SRPM URL: https://github.com/pmikova/fedora-packaging-jrd/raw/master/java-runtime-decompiler-2.0-1.fc30.src.rpm Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
