Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Sirius - Othello game for GNOME https://bugzilla.redhat.com/show_bug.cgi?id=287801 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-09-19 11:52 EST ------- For 0.8.0-2: * First for long sirius-0.8.0-autoreconf.patch.bz2 - Plese don't use such uselessly long patch. This makes it harder to find what actually has to be fixed by this patch. * If you have to use autotools, please use autotools, not use such long patch. * However using autotools is highly _not_ recommended. Please investigate the points which should really be fixed. - By the way, is this really needed? ppc64 rebuild succeeds without this patch. * perl modules BuildRequires (also refer to http://fedoraproject.org/wiki/Packaging/Perl ) - For perl modules, please don't write rpm name for BuildRequires. Instead, write the module name for BuildRequires like: BuildRequires: perl(XML::Parser) * License - License seems to be GPLv2+. * CFLAGS ----------------------------------------------- %build %configure make %{?_smp_mflags} CFLAGS="%{optflags}" ----------------------------------------------- - Check if CFLAGS option in the last line is really needed. Usually this is not needed (please check what %configure does by: $ rpm --eval %configure ) * Timestamp - To keep timestamp, I recommend: ----------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="%{__install} -p" ----------------------------------------------- The method above usually works on recent Makefiles. * desktop category - Category "Application" is deprecated and should be removed. * rpmlint ------------------------------------------------ sirius.i386: W: file-not-utf8 /usr/share/doc/sirius-0.8.0/AUTHORS sirius.i386: W: file-not-utf8 /usr/share/doc/sirius-0.8.0/ChangeLog sirius.i386: W: file-not-utf8 /usr/share/doc/sirius-0.8.0/README ------------------------------------------------ - Please change the encoding of these files to UTF-8. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review