[Bug 1650969] Review Request: perl-Mojo-SQLite - Tiny Mojolicious wrapper for SQLite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1650969

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
04b790d65b2a2d9fd1eaad52a72055c46f61aa3cad09bbe959ce2db167ad3ebe) is original.
Ok.
Summary verified from lib/Mojo/SQLite.pm. Ok.
Description verified from lib/Mojo/SQLite.pm. Ok.
License verified from lib/Mojo/SQLite.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-Mojo-SQLite.spec
review-perl-Mojo-SQLite/results/perl-Mojo-SQLite-3.001-1.fc30.noarch.rpm
review-perl-Mojo-SQLite/results/perl-Mojo-SQLite-3.001-1.fc30.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpm -q -lv -p perl-Mojo-SQLite-3.001-1.fc30.noarch.rpm 
drwxr-xr-x    2 root    root                        0 nov. 18 17:18
/usr/share/doc/perl-Mojo-SQLite
-rw-r--r--    1 root    root                     4430 juil. 21 02:25
/usr/share/doc/perl-Mojo-SQLite/CONTRIBUTING.md
-rw-r--r--    1 root    root                     5743 juil. 21 02:25
/usr/share/doc/perl-Mojo-SQLite/Changes
-rw-r--r--    1 root    root                    14738 juil. 21 02:25
/usr/share/doc/perl-Mojo-SQLite/README
drwxr-xr-x    2 root    root                        0 nov. 18 17:18
/usr/share/licenses/perl-Mojo-SQLite
-rw-r--r--    1 root    root                     9037 juil. 21 02:25
/usr/share/licenses/perl-Mojo-SQLite/LICENSE
-rw-r--r--    1 root    root                     7077 nov. 18 17:18
/usr/share/man/man3/Mojo::SQLite.3pm.gz
-rw-r--r--    1 root    root                     4429 nov. 18 17:18
/usr/share/man/man3/Mojo::SQLite::Database.3pm.gz
-rw-r--r--    1 root    root                     3321 nov. 18 17:18
/usr/share/man/man3/Mojo::SQLite::Migrations.3pm.gz
-rw-r--r--    1 root    root                     2072 nov. 18 17:18
/usr/share/man/man3/Mojo::SQLite::PubSub.3pm.gz
-rw-r--r--    1 root    root                     3270 nov. 18 17:18
/usr/share/man/man3/Mojo::SQLite::Results.3pm.gz
-rw-r--r--    1 root    root                     2341 nov. 18 17:18
/usr/share/man/man3/Mojo::SQLite::Transaction.3pm.gz
drwxr-xr-x    2 root    root                        0 nov. 18 17:18
/usr/share/perl5/vendor_perl/Mojo
drwxr-xr-x    2 root    root                        0 nov. 18 17:18
/usr/share/perl5/vendor_perl/Mojo/SQLite
-rw-r--r--    1 root    root                    17554 nov. 18 17:18
/usr/share/perl5/vendor_perl/Mojo/SQLite.pm
-rw-r--r--    1 root    root                    11146 nov. 18 17:18
/usr/share/perl5/vendor_perl/Mojo/SQLite/Database.pm
-rw-r--r--    1 root    root                     7025 nov. 18 17:18
/usr/share/perl5/vendor_perl/Mojo/SQLite/Migrations.pm
-rw-r--r--    1 root    root                      816 nov. 18 17:18
/usr/share/perl5/vendor_perl/Mojo/SQLite/PubSub.pm
-rw-r--r--    1 root    root                     5451 nov. 18 17:18
/usr/share/perl5/vendor_perl/Mojo/SQLite/Results.pm
-rw-r--r--    1 root    root                     2025 nov. 18 17:18
/usr/share/perl5/vendor_perl/Mojo/SQLite/Transaction.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Mojo-SQLite-3.001-1.fc30.noarch.rpm | sort -f |
uniq -c
      1 perl(:MODULE_COMPAT_5.28.0)
      1 perl(Carp)
      1 perl(constant)
      1 perl(DBD::SQLite)
      1 perl(DBI)
      1 perl(File::Spec::Functions)
      1 perl(File::Temp)
      1 perl(Mojo::Base)
      1 perl(Mojo::Collection)
      1 perl(Mojo::File)
      1 perl(Mojo::IOLoop)
      1 perl(Mojo::JSON)
      1 perl(Mojo::Loader)
      1 perl(Mojo::SQLite::Database)
      1 perl(Mojo::SQLite::Migrations)
      1 perl(Mojo::SQLite::Results)
      1 perl(Mojo::SQLite::Transaction)
      1 perl(Mojo::Util)
      1 perl(Scalar::Util)
      1 perl(SQL::Abstract)
      1 perl(URI)
      1 perl(URI::db)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.


$ rpm -q --provides -p perl-Mojo-SQLite-3.001-1.fc30.noarch.rpm 
perl(Mojo::SQLite) = 3.001
perl(Mojo::SQLite::Database) = 3.001
perl(Mojo::SQLite::Migrations) = 3.001
perl(Mojo::SQLite::PubSub) = 3.001
perl(Mojo::SQLite::Results) = 3.001
perl(Mojo::SQLite::Transaction) = 3.001
perl-Mojo-SQLite = 3.001-1.fc30
Binary provides are Ok.

Package builds in Mock.
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux