[Bug 1649930] Review Request: golang-gopkg-square-jose - An implementation of JOSE standards (JWE, JWS, JWT) in Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1649930

Carl George <carl@george.computer> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Carl George <carl@george.computer> ---
I discovered a few other items.

Must fix:

The json directory contains a fork of the standard library json, which is BSD
licensed.  Change the License field to `ASL 2.0 and BSD` and include
json/LICENSE in %files.

The changelog entry still says 2.1.8 but the version is 2.1.9.

Optional fix:

The utility commands have their own README files (jose-util/README.md and
jwk-keygen/README.md), I would consider including those in %files.  Of course
they will have to be renamed (README-jose-util.md and README-jwk-keygen.md
perhaps) to not overwrite the top level README.md.

Pending those fixes, PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux