https://bugzilla.redhat.com/show_bug.cgi?id=1649952 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST --- Comment #6 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Miro Hrončok from comment #1) > Out of curiosity. Is there any specific reason to add python2 package to > Fedora 29 just to not add it in Fedora 30? At the moment, I'm doing it simply because we can provide a python2 version in F29. Researchers are sometimes finicky about what version they use. In the future, we may provide neurofedora packages to EPEL etc too, if researchers require it, then this type of general spec will be easier to tweak (or so I think). (In reply to Miro Hrončok from comment #2) > The test seem fixed upstream. Would it be possible to backport the fix? Done. I've included the required patches and enabled the tests. (In reply to Miro Hrončok from comment #3) > I'd recommend using > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_automatically_generated_dependencies Done. I'll double check that the generated requires are complete. I've seen a few python packages that do not include the complete set of requirements :/ (In reply to Miro Hrončok from comment #4) > The docs won't build in mock without python2-sphinx. > Set SPHINXBUILD=sphinx-build-3 explicitly when running make html. > (Untested, so only 90 % sure.) I've added this, but currently docs don't build so they're still disabled. (In reply to Miro Hrončok from comment #5) > Several language things: > > - I think that en_US would use serialization over serialisation (yet I'm not > an expert) Yes, corrected. > - Documentatation is a typo Corrected too. Thanks for the quick review. Updated spec/srpm here: https://ankursinha.fedorapeople.org/python-nineml/python-nineml.spec https://ankursinha.fedorapeople.org/python-nineml/python-nineml-1.0-2.fc29.src.rpm New rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30905438 Requested SCM here https://pagure.io/releng/fedora-scm-requests/issue/8852 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
