[Bug 1649573] Review Request: directory-maven-plugin - Establish locations for files in multi-module builds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1649573



--- Comment #6 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> ---
>From the spec:

BuildRequires:  javapackages-tools
BuildRequires:  maven-local
BuildRequires:  maven-parent
BuildRequires:  maven-plugin-plugin
BuildRequires:  maven-javadoc-plugin
BuildRequires:  sonatype-oss-parent

Please use mvn()-style BR's whenever possible:
$ dnf -q repoquery --provides maven-plugin-plugin | grep 'mvn('
mvn(org.apache.maven.plugins:maven-plugin-plugin) = 3.5.1
mvn(org.apache.maven.plugins:maven-plugin-plugin:pom:) = 3.5.1

That's a more accurate reflection of what's in the poms. But taking a closer
look at the upstream pom I see these deps:

    <dependency>
      <groupId>junit</groupId>
      <artifactId>junit</artifactId>
      <version>4.8.2</version>
      <scope>test</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.maven</groupId>
      <artifactId>maven-core</artifactId>
    </dependency>
    <dependency>
      <groupId>org.apache.maven</groupId>
      <artifactId>maven-plugin-api</artifactId>
    </dependency>
    <dependency>
      <groupId>org.apache.maven</groupId>
      <artifactId>maven-model</artifactId>
    </dependency>

That would translate to:

mvn(org.apache.maven:maven-model)
mvn(org.apache.maven:maven-plugin-api)
mvn(org.apache.maven:maven-core)
mvn(junit:junit)

Is the above and maven-local not sufficient?

Requires:   java-openjdk

I believe a java dependency will be auto-generated for you. No need to add
this.

%files
%{_javadir}/%{name}
%{_javadocdir}/%{name}
%{_datadir}/maven-poms/%{name}
%{_datadir}/maven-metadata/%{name}.xml

Please use:

%files -f .mfiles

Regarding maven-javadoc-plugin BuildRequirement:

Consider using Xmvn's built-in mechanism. Soemthing like this should work:
https://src.fedoraproject.org/rpms/byteman/c/bfb4d668ca56d70d8aa76ae089ac686d72ba3b4c?branch=master

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux