https://bugzilla.redhat.com/show_bug.cgi?id=1645172 --- Comment #14 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Ondrej Dubaj from comment #13) > Thank you for your help. > > Posting modified spec file and srpm according to your comments: > > Spec URL: > https://raw.githubusercontent.com/odubaj/firejail/master/firejail.spec > SRPM URL: > https://raw.githubusercontent.com/odubaj/firejail/master/firejail-0.9.56-3. > fc28.src.rpm > > Mail to upstream according to license is sent, waiting for approval. %config(noreplace) /etc/bash-completion.d/completions/* I think this is wrong. IMHO the completion scripts should go directly under /etc/bash-completion.d/ Could you check whether the completion is working? chmod 0755 %{buildroot}%{_bindir}/%{name} You are removing the SUID bit, I think it will not work correctly. This line should be removed. Which problem you have with the SUID? Could you post your build error? It builds OK for me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
