https://bugzilla.redhat.com/show_bug.cgi?id=1646582 --- Comment #3 from Lubomir Rintel <lkundrak@xxxxx> --- (In reply to Robert-André Mauchin from comment #1) Thanks for your review. perl-Net-IMAP-Client is now in BR override so this now builds in Koji successfully. > - Duplicate line: > > BuildRequires: file-devel > BuildRequires: file-devel Good catch, will fix. > - Group: is not used in Fedora Yeah, but... It's not a "MUST NOT" and certain tools (rpm -qi) still print it. I'd prefer to have it correct than to have is missing unless the rest of the tooling really really gets rid of it. > - Could use %autosetup -p1 instead of: > > %setup -q > %patch0 -p1 > %patch1 -p1 Yes. Both forms look equally good to me; and I guess the guidelines allow both. I'm more used to this one and I guess there's no harm in keeping things working on versions that predate %autosetup. > - %{_prefix}/lib/lumail > > Suspicious, shouldn't this be in %{_libdir}? You should overwrite > LUMAIL_LIBS?=$(DESTDIR)$(PREFIX)/lib/lumail It is correct. We're not installing arch-dependent files, but lua libraries. Cheers Lubo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
