[Bug 1649750] Review Request: python-pyemd - Fast EMD for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1649750



--- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> > BuildRequires:  gcc gcc-c++
> One-per-line please.
> 
> > export PYTHONPATH=$RPM_BUILD_ROOT/%{python2_sitearch}
> I think %{buildroot} is nowadays considered nicer, but this is acceptable of
> course.
> 


Thanks for the review, Zbigniew! Updated both. 


Spec URL: https://ankursinha.fedorapeople.org/python-pyemd/python-pyemd.spec
SRPM URL:
https://ankursinha.fedorapeople.org/python-pyemd/python-pyemd-0.5.1-1.fc29.src.rpm

(Didn't bump the release for these, but noted in changelog)

SCM requested: https://pagure.io/releng/fedora-scm-requests/issue/8834

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux