https://bugzilla.redhat.com/show_bug.cgi?id=1649058 --- Comment #1 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Package Review ============== Looks good. Only the directory ownership is an issue that really needs to be clarified for golang packages in general. As soon as that's sorted it'll be approved. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License (v2.0)", "Unknown or generated", "Apache License (v2.0)". 22 files have unknown license. Detailed output of licensecheck in /home/asinha/1649058-golang-github-census- instrumentation-opencensus-proto/licensecheck.txt [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode Same issue as the other golang packages. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com(golang) But the golang package is not needed by this one, so there's no need to include it as a Requires. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-census-instrumentation-opencensus-proto-devel-0.1.0-1.fc29.noarch.rpm golang-github-census-instrumentation-opencensus-proto-0.1.0-1.fc29.src.rpm golang-github-census-instrumentation-opencensus-proto-devel.noarch: W: spelling-error %description -l en_US natively -> naively, negatively, tentatively golang-github-census-instrumentation-opencensus-proto-devel.noarch: W: spelling-error %description -l en_US protos -> protons, proton, promos golang-github-census-instrumentation-opencensus-proto-devel.noarch: W: spelling-error %description -l en_US interoperability -> interchangeability, invulnerability, inseparability golang-github-census-instrumentation-opencensus-proto-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/census-instrumentation/opencensus-proto/.goipath Required. False positive. golang-github-census-instrumentation-opencensus-proto.src: W: spelling-error %description -l en_US natively -> naively, negatively, tentatively golang-github-census-instrumentation-opencensus-proto.src: W: spelling-error %description -l en_US protos -> protons, proton, promos golang-github-census-instrumentation-opencensus-proto.src: W: spelling-error %description -l en_US interoperability -> interchangeability, invulnerability, inseparability golang-github-census-instrumentation-opencensus-proto.src: W: no-%build-section Not needed from the looks of it. 2 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory golang-github-census-instrumentation-opencensus-proto-devel.noarch: W: spelling-error %description -l en_US natively -> naively, negatively, tentatively golang-github-census-instrumentation-opencensus-proto-devel.noarch: W: spelling-error %description -l en_US protos -> protons, proton, promos golang-github-census-instrumentation-opencensus-proto-devel.noarch: W: spelling-error %description -l en_US interoperability -> interchangeability, invulnerability, inseparability golang-github-census-instrumentation-opencensus-proto-devel.noarch: W: invalid-url URL: https://github.com/census-instrumentation/opencensus-proto <urlopen error [Errno -2] Name or service not known> golang-github-census-instrumentation-opencensus-proto-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/census-instrumentation/opencensus-proto/.goipath 1 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- golang-github-census-instrumentation-opencensus-proto-devel (rpmlib, GLIBC filtered): golang(github.com/golang/protobuf/proto) golang(github.com/golang/protobuf/ptypes/timestamp) golang(github.com/golang/protobuf/ptypes/wrappers) golang(golang.org/x/net/context) golang(google.golang.org/grpc) Provides -------- golang-github-census-instrumentation-opencensus-proto-devel: golang(github.com/census-instrumentation/opencensus-proto/gen-go/agent/common/v1) golang(github.com/census-instrumentation/opencensus-proto/gen-go/agent/metrics/v1) golang(github.com/census-instrumentation/opencensus-proto/gen-go/agent/trace/v1) golang(github.com/census-instrumentation/opencensus-proto/gen-go/exporter/v1) golang(github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1) golang(github.com/census-instrumentation/opencensus-proto/gen-go/resource/v1) golang(github.com/census-instrumentation/opencensus-proto/gen-go/stats/v1) golang(github.com/census-instrumentation/opencensus-proto/gen-go/trace/v1) golang-github-census-instrumentation-opencensus-proto-devel golang-ipath(github.com/census-instrumentation/opencensus-proto) Source checksums ---------------- https://github.com/census-instrumentation/opencensus-proto/archive/v0.1.0.tar.gz#/opencensus-proto-0.1.0.tar.gz : CHECKSUM(SHA256) this package : 4fd21cc6de63d7cb979fd749d8101ff425905aa0826fed26019d1c311fcf19a7 CHECKSUM(SHA256) upstream package : 4fd21cc6de63d7cb979fd749d8101ff425905aa0826fed26019d1c311fcf19a7 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1649058 Buildroot used: fedora-29-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
