[Bug 1515053] Review Request: asv - Airspeed Velocity: A simple Python history benchmarking tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1515053



--- Comment #12 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
Almost there. One or two issues remaining.

I've filed a bug against Pympler asking if asizeof should be marked as bundled
here: https://bugzilla.redhat.com/show_bug.cgi?id=1649274 (I expect it should,
like we do in nibabel
https://src.fedoraproject.org/rpms/python-nibabel/blob/master/f/python-nibabel.spec#_46)

rpmlint still catches a few issues:

asv.x86_64: E: wrong-script-interpreter
/usr/lib64/python3.7/site-packages/asv/extern/asizeof.py /usr/bin/env python
asv.x86_64: E: non-executable-script
/usr/lib64/python3.7/site-packages/asv/extern/asizeof.py 644 /usr/bin/env
python

Please correct these.

asv.x86_64: W: dangling-symlink
/usr/lib64/python3.7/site-packages/asv/www/vendor/jquery-3.2.1.js
/usr/share/javascript/jquery/3.2.1/jquery.js
asv.x86_64: W: dangling-symlink
/usr/lib64/python3.7/site-packages/asv/www/vendor/jquery.flot-0.8.3.categories.min.js
/usr/lib/node_modules/flot/jquery.flot.categories.min.js
asv.x86_64: W: dangling-symlink
/usr/lib64/python3.7/site-packages/asv/www/vendor/jquery.flot-0.8.3.min.js
/usr/lib/node_modules/flot/jquery.flot.min.js
asv.x86_64: W: dangling-symlink
/usr/lib64/python3.7/site-packages/asv/www/vendor/jquery.flot-0.8.3.selection.min.js
/usr/lib/node_modules/flot/jquery.flot.selection.min.js
asv.x86_64: W: dangling-symlink
/usr/lib64/python3.7/site-packages/asv/www/vendor/jquery.flot-0.8.3.time.min.js
/usr/lib/node_modules/flot/jquery.flot.time.min.js

These need to be double checked. Pympler does something similar, so that could
be used as reference:
https://src.fedoraproject.org/rpms/python-Pympler/blob/master/f/python-Pympler.spec#_70

Cheers,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux