https://bugzilla.redhat.com/show_bug.cgi?id=1648966 --- Comment #3 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #2) > - Should this and other similar packages require golang which owns > /usr/share/gocode/src? > > I don't think so. Based on my understanding of the guidelines, I think they should either require the golang package, or own the directory themselves. This is what the guidelines say: "Packages must own all directories they put files in, except for: - any directories owned by the filesystem, man, or other explicitly created -filesystem packages - any directories owned by other packages in your package's natural dependency chain" So, here, since this package doesn't require golang explicitly and doesn't pull it in as a natural dependency either (not listed in requires as generated by fedora-review above), `/usr/share/gocode/src` (and /usr/share/gocode) is currently unowned. So when this package is removed, for example, this directory will get left behind. https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership I'm not a golang user, but isn't golang required to use this package anyway? If it isn't, it is this case: https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function If it is, then it's this one: https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package Either way, the two directories need to be owned here. > > - Shouldn't the release include snapshot information? > > It's computed automatically in dist by the gometa macro Ah, right. So many go marcos now, doing so many fancy things! > > - rpmlint says there's a hidden file in the directories---I expect this is > required, but please double check. > > It's the .goipath file, which is required. I thought so. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
