[Bug 1509679] Review Request: rofi - A window switcher, application launcher and dmenu replacement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1509679



--- Comment #18 from Jan Pokorný <jpokorny@xxxxxxxxxx> ---
> For the sake of completeness, I'd suggest:
> 
>   s#/usr/bin/${interpreter}#%{_bindir}/${interpreter}#
> 
> but is not a blocker here (note that possibly python* dealing in the same
> location in the spec file is merely an overapproximation, so no crossing
> into Python specific guidelines takes place, I'd suggest dropping those
> mentions, actually).

Actually, ditching that handling altogether will make the implicit
rpm scripts do the Right Thing:

> + /usr/lib/rpm/redhat/brp-mangle-shebangs
> mangling shebang in /usr/bin/rofi-sensible-terminal from /usr/bin/env bash to #!/usr/bin/bash
> mangling shebang in /usr/bin/rofi-theme-selector from /usr/bin/env bash to #!/usr/bin/bash

so best to just rely on that.

* * *

Also have noticed that there's likely no good reason to ship *.md5 files
in -devel-doc (my understanding is that it tells doxygen which source
got updated, and that's not needed here, since that documentation is not
to be regenerated directly at one's machines at that system location).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux