Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: outerspace - client for 4x on-line strategy game https://bugzilla.redhat.com/show_bug.cgi?id=253781 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-09-19 03:45 EST ------- Almost okay for this package. * Macros in %changelog - rpmlint shows the following complaint on -2.fc7.src.rpm --------------------------------------------------------------- outerspace.src:70: W: macro-in-%changelog files --------------------------------------------------------------- When writing macros in %changelog, please use %% to prevent macros from being expanded, for example: --------------------------------------------------------------- * Tue Sep 18 2007 Qark <qark@xxxxxxxxxx> 0.2.2-2 - Removed dependency on Python - Simplified %%files section --------------------------------------------------------------- So, as sponsor process requires, please - pre-review other person's review request - or submit another review request as I wrote in comment 7. (In reply to comment #8) > I don't agree with replacing file with link as it can break when upstream > changes theme for GUI (which is very likely). - You can simply change when it occurs. > I really don't like doing any Fedora specific > fixes, - Actually many srpm in Fedora have many Fedora specific fixes and they are actually necessary :) > I wonder why spec file based on already reviewed spec > file got so many comments. - I just say that Nicholas's comment is just a preview. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review