[Bug 1509679] Review Request: rofi - A window switcher, application launcher and dmenu replacement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1509679



--- Comment #14 from Jan Pokorný <jpokorny@xxxxxxxxxx> ---
I think only these two points remain and I have nothing more
(in Fedora, there's apparently nothing like x-terminal-emulator,
older xdg initiative likely and sadly went nowhere as well:
https://lists.freedesktop.org/archives/xdg/2006-December/007290.html):

- s/pkgconfig(xcb-util)/pkgconfig(xcb-aux)/
  (same package but for consistency ...)

- there's an interesting situation regarding licensing, and I was
  surprised not seeing that discussed anywhere in Fedora context,
  since lexer/theme-parser.[ch] (these are intermediate products
  likely provided for convenience for direct consumption by upstream,
  since they would get regenerated in mock anew otherwise)
  are effectively "GPLv3+ with exceptions", whereby the exception
  itself is that

> [you may] distribute that work under terms of your choice [...]

Also have found a direct reference indicating it's nothing
accidental:
https://spdx.org/licenses/GPL-2.0-with-bison-exception.html
likely from times Bison used to be GPLv2[+], and that such exception
wasn't granted before:
https://www.gnu.org/software/bison/manual/bison.html#Conditions
(it could also imply that some years back, rofi, if it existed,
could not arbitrarily mix this GPL licensed generated code with
its own MIT code, but take this with a grain of salt, and it's
irrelevant these days, anyway).

Perhaps would add a comment, that those files are "GPLv3+ with
Bison exception" and hence the project's MIT license is applicable,
to clear out any doubts from superficial peek into licensecheck
output and whatnot.

Thanks.  Will fix the findings for grim/slurp shortly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux