https://bugzilla.redhat.com/show_bug.cgi?id=1648444 Bug ID: 1648444 Summary: Review Request: vdr-graphlcd - VDR plugin: Output to graphic LCD Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: mgansser@xxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-osd2web.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-graphlcd-1.0.0-1.fc29.src.rpm Description: graphlcd is a plugin for the Video Disc Recorder and shows information about the current state of VDR on displays supported by the GraphLCD driver library. Fedora Account System Username: martinkg rpmlint -i -v vdr-graphlcd.spec /home/martin/rpmbuild/SRPMS/vdr-graphlcd-1.0.0-1.fc29.src.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-graphlcd-1.0.0-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-graphlcd-debugsource-1.0.0-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-graphlcd-debuginfo-1.0.0-1.fc29.x86_64.rpm vdr-graphlcd.spec: I: checking vdr-graphlcd.spec:54: W: macro-in-comment %config There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. vdr-graphlcd.spec:54: W: macro-in-comment %{vdr_plugin_cfgdir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. vdr-graphlcd.spec: I: checking-url https://projects.vdr-developer.org/git/vdr-plugin-graphlcd.git/snapshot/vdr-plugin-graphlcd-1.0.0.tar.bz2 (timeout 10 seconds) vdr-graphlcd.src: I: checking vdr-graphlcd.src: I: checking-url http://graphlcd.berlios.de/ (timeout 10 seconds) vdr-graphlcd.src: W: invalid-url URL: http://graphlcd.berlios.de/ <urlopen error [Errno -2] Name or service not known> The value should be a valid, public HTTP, HTTPS, or FTP URL. vdr-graphlcd.src:54: W: macro-in-comment %config There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. vdr-graphlcd.src:54: W: macro-in-comment %{vdr_plugin_cfgdir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. vdr-graphlcd.src: I: checking-url https://projects.vdr-developer.org/git/vdr-plugin-graphlcd.git/snapshot/vdr-plugin-graphlcd-1.0.0.tar.bz2 (timeout 10 seconds) vdr-graphlcd.x86_64: I: checking vdr-graphlcd.x86_64: I: checking-url http://graphlcd.berlios.de/ (timeout 10 seconds) vdr-graphlcd.x86_64: W: invalid-url URL: http://graphlcd.berlios.de/ <urlopen error [Errno -2] Name or service not known> The value should be a valid, public HTTP, HTTPS, or FTP URL. vdr-graphlcd.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/vdr/plugins/graphlcd/channels.alias A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var. vdr-graphlcd.x86_64: W: file-not-utf8 /usr/share/doc/vdr-graphlcd/HISTORY The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). vdr-graphlcd.x86_64: E: incorrect-fsf-address /usr/share/licenses/vdr-graphlcd/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/DejaVuSans-Bold.ttf /usr/share/fonts/dejavu/DejaVuSans-Bold.ttf The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/DejaVuSansCondensed.ttf /usr/share/fonts/dejavu/DejaVuSansCondensed.ttf The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/Vera.ttf /usr/share/fonts/bitstream-vera/Vera.ttf The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. vdr-graphlcd.x86_64: W: dangling-symlink /usr/share/vdr/plugins/graphlcd/fonts/VeraBd.ttf /usr/share/fonts/bitstream-vera/VeraBd.ttf The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. vdr-graphlcd-debugsource.x86_64: I: checking vdr-graphlcd-debugsource.x86_64: I: checking-url http://graphlcd.berlios.de/ (timeout 10 seconds) vdr-graphlcd-debugsource.x86_64: W: invalid-url URL: http://graphlcd.berlios.de/ <urlopen error [Errno -2] Name or service not known> The value should be a valid, public HTTP, HTTPS, or FTP URL. vdr-graphlcd-debuginfo.x86_64: I: checking vdr-graphlcd-debuginfo.x86_64: I: checking-url http://graphlcd.berlios.de/ (timeout 10 seconds) vdr-graphlcd-debuginfo.x86_64: W: invalid-url URL: http://graphlcd.berlios.de/ <urlopen error [Errno -2] Name or service not known> The value should be a valid, public HTTP, HTTPS, or FTP URL. 4 packages and 1 specfiles checked; 1 errors, 14 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx