https://bugzilla.redhat.com/show_bug.cgi?id=1647145 --- Comment #4 from Dan Williams <dan.j.williams@xxxxxxxxx> --- (In reply to Marcin Ślusarz from comment #2) > (In reply to Dan Williams from comment #1) > > Why the usage of: > > > > %global debug_package %{nil} > > > > ...this breaks standard profiling and debug flows. > > libpmemobj-cpp is header-only library, so there is no need for debug > packages. Ah, ok, I guess this is what happens when you get a Linux kernel dev to review a C++ package. > > Have you already run fedora-review and addressed the reported issues? > > No, not yet. I'm working on that. Ok. > > Is there a plan or list of dependencies identified before PMDK can be built > > on other architectures? I would file bugzilla's for those requirements as > > recommended here: > > > > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > > Guidelines#Architecture_Support > > > > ...and then reference them in the spec file. > > PMDK spec already has the list of bugs (#1340634, #1340635, #1340636, > #1340637). Do I have to copy this list here? Yes, just duplicate the same list in this spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
