[Bug 1643764] Review Request: intelhex - A python library for manipulating Intel HEX file format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1643764



--- Comment #4 from Peter Robinson <pbrobinson@xxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #3)
>  - As Henrek said this should be named python-intelhex with a python3
> subpackage.

Why? I really don't see the point and traditionally the package source name has
been the upstream project name.

>  - It is now forbidden to glob %{python3_sitelib}/*, see
> https://fedoraproject.org/wiki/Packaging:Python#Files_to_include
> Be more specific instead.

Updated.

>  - You should add AUTHORS.rst NEWS.rst Readme.rst to %doc

The first two make sense, the readme doesn't as all the information is either
covered in the %description, the %license or irrelevant like
download/install/python versions supported.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux