[Bug 1647311] Review Request: perl-Plack-Middleware-Session - Middleware for session management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1647311

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
FIX: Please remove duplicate BR 'perl(Cookie::Baker)'.
     'perl(Test::Pod)' is used only for release testing, so it can be
     removed.

$ rpm -qp --requires perl-Plack-Middleware-Session-0.30-1.fc30.noarch.rpm |
sort | uniq -c
      1 perl(Cookie::Baker)
      1 perl(Digest::HMAC_SHA1)
      1 perl(Digest::SHA1)
      1 perl(MIME::Base64)
      1 perl(:MODULE_COMPAT_5.28.0)
      1 perl(parent)
      1 perl(Plack::Middleware)
      1 perl(Plack::Middleware::Session)
      1 perl(Plack::Request)
      1 perl(Plack::Session::Cleanup)
      1 perl(Plack::Session::State)
      1 perl(Plack::Session::State::Cookie)
      1 perl(Plack::Session::Store)
      1 perl(Plack::Util)
      1 perl(Plack::Util::Accessor)
      1 perl(Scalar::Util)
      1 perl(Storable)
      1 perl(strict)
      1 perl(Time::HiRes)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Plack-Middleware-Session-0.30-1.fc30.noarch.rpm |
sort | uniq -c
      1 perl(Plack::Middleware::Session) = 0.30
      1 perl-Plack-Middleware-Session = 0.30-1.fc30
      1 perl(Plack::Middleware::Session::Cookie)
      1 perl(Plack::Session) = 0.30
      1 perl(Plack::Session::Cleanup) = 0.30
      1 perl(Plack::Session::State) = 0.30
      1 perl(Plack::Session::State::Cookie) = 0.30
      1 perl(Plack::Session::Store) = 0.30
      1 perl(Plack::Session::Store::Cache) = 0.30
      1 perl(Plack::Session::Store::DBI) = 0.30
      1 perl(Plack::Session::Store::File) = 0.30
      1 perl(Plack::Session::Store::Null) = 0.30
Binary provides are Ok.

$ rpmlint ./perl-Plack-Middleware-Session*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

Otherwise the package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux