https://bugzilla.redhat.com/show_bug.cgi?id=1645917 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Thanks for the review, Robert! (In reply to Robert-André Mauchin from comment #1) > - Use %bcond_with/bcond_without for these: These commands do not work on koji, so I don't find them particularly useful. I've got to then change the spec before committing to SCM, and I only use scratch builds to test my packages where these commands don't work either. > > # Multiple tests fail > %global run_tests 0 > > # The documentation fails to build on F29, so we'll just point to upstream > # documentation > %global with_doc 0 > > > # Requires nibabel which is only available for python3-nibabel > %global with_py2 0 > > > - Py2 package: THANKS should be in a %doc not %license Gah---corrected. > > - Build was successful with doc and tests in Rawhide. I suggest enabling > them. Unfortunately not. The tests fail on i686: https://koji.fedoraproject.org/koji/taskinfo?taskID=30715258 Igor already reported these upstream. I've added the tickets as comments to the spec file (and bumped them too). I've enabled the docs on rawhide (F30+). > > - Remove the sphinx-build leftovers: > > python-nitime-doc.x86_64: W: hidden-file-or-dir > /usr/share/doc/python-nitime-doc/html/.buildinfo Removed. > > - You doc subpackage should be noarch Corrected. > Generic: > [!]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > Note: Arch-ed rpms have a total of 8376320 bytes in /usr/share This was the -doc sub package that has been corrected. > series, Time-series, Timeservers > python3-nitime.x86_64: W: spelling-error Summary(en_US) neuroscience -> > pseudoscience > python3-nitime.x86_64: W: spelling-error %description -l en_US neuroscience > -> pseudoscience Eh? Neuroscience is NOT pseudoscience!! XD > python-nitime-doc.x86_64: W: summary-ended-with-dot C Documentation for > python-nitime. Corrected. > python-nitime-doc.x86_64: W: hidden-file-or-dir > /usr/share/doc/python-nitime-doc/html/.buildinfo Removed. New F29 build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30715539 New rawhide build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30715529 Updated spec/srpm: https://ankursinha.fedorapeople.org/python-nitime/python-nitime.spec https://ankursinha.fedorapeople.org/python-nitime/python-nitime-0.8-0.2.git1fab571.fc29.src.rpm Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
