https://bugzilla.redhat.com/show_bug.cgi?id=1645848 --- Comment #9 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Michael Schwendt from comment #8) > > Can you please be more clear on what I'm missing here? Is it the addition of > > -O3 to the flags? I've corrected that bit now, but you'll have to point out > > what else I'm missing, I'm afraid. > > Yes, -O3 and possibly more flags that override Fedora's defaults. The > guidelines offer multiple choices how to handle such a case. Removing -O3 is > the most plausible option. I've removed the flags that upstream was adding. > > > > I've now copied bits from wikipedia too. How is this? > > The primary issue remains. The base package "libb64" does not contain a > library. It also doesn't contain the source code. It contains only the > command-line executable with nothing in the %description commenting on it or > its strengths compared with the tool from coreutils. > > Is the primary interest in the library and API or the executable? I > understand that you need the lib as buildreq for other packages, but if > shipping the tool in a separate non-devel package starting with a "lib" > prefix in its name, the package description should mention that. > > Note that you could also build a "libb64-tools" subpackage instead, even if > it's only a single executable. I've updated the description of the main package to mention that it includes the tool, and that users should install the -devel package if they wish to develop using the library: "This package provides the %{name}-b64 binary tool for encoding to and decoding from the Base64 scheme. Please install the %{name}-devel package to develop software using %{name}." Do you think that's clear enough? If not, I'll put the binary into a separate -tools subpackage. Updated spec/srpm: https://ankursinha.fedorapeople.org/libb64/libb64.spec https://ankursinha.fedorapeople.org/libb64/libb64-1.2-3.fc29.src.rpm Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
