https://bugzilla.redhat.com/show_bug.cgi?id=1646795 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- This: %license %{_pkgdocdir}/*/COPYING %license %{_pkgdocdir}/*/LICENSE %license %{_datadir}/ansible/roles/%{roleprefix}kdump/COPYING %license %{_datadir}/ansible/roles/%{roleprefix}postfix/COPYING %license %{_datadir}/ansible/roles/%{roleprefix}selinux/COPYING %license %{_datadir}/ansible/roles/%{roleprefix}timesync/COPYING %license %{_datadir}/ansible/roles/%{roleprefix}network/LICENSE ain't gonna work. You'll end up overwriting COPYING and LICENSE files. You need to rename them first then install them. - Don't %doc files already in %{_pkgdocdir} %doc %{_pkgdocdir}/*/example-*-playbook.yml %doc %{_pkgdocdir}/network/example-inventory %doc %{_pkgdocdir}/timesync/example-multiple-ntp-servers.yml %doc %{_pkgdocdir}/timesync/example-single-pool.yml %doc %{_pkgdocdir}/*/README.md %doc %{_pkgdocdir}/*/README.html - This won't work either, it will overwrite the READMEs: %doc %{_datadir}/ansible/roles/%{roleprefix}kdump/README.md %doc %{_datadir}/ansible/roles/%{roleprefix}postfix/README.md %doc %{_datadir}/ansible/roles/%{roleprefix}selinux/README.md %doc %{_datadir}/ansible/roles/%{roleprefix}timesync/README.md %doc %{_datadir}/ansible/roles/%{roleprefix}network/README.md %doc %{_datadir}/ansible/roles/%{roleprefix}kdump/README.html %doc %{_datadir}/ansible/roles/%{roleprefix}postfix/README.html %doc %{_datadir}/ansible/roles/%{roleprefix}selinux/README.html %doc %{_datadir}/ansible/roles/%{roleprefix}timesync/README.html %doc %{_datadir}/ansible/roles/%{roleprefix}network/README.html Also I don't see how this is necessary as you already copied the READMEs in pkgdocdir. You shouldn't copy the licenses in pkgdocdir too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
