https://bugzilla.redhat.com/show_bug.cgi?id=1645848 --- Comment #5 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Michael Schwendt from comment #4) > * /usr/bin/base64 conflicts with coreutils [!] Ugh, and it seems to do the exact same thing too. However, coreutils does not provide the headers or the lib that this provides (and biosig needs). Would it be OK to rename this binary to differentiate it from the one coreutils provides? $ sudo dnf whatprovides '*/cencode.h' Io-language-devel-20151111-0.e64ff9.fc29.13.i686 : Development files for Io-language Repo : fedora Matched from: Filename : /usr/include/io/cencode.h Io-language-devel-20151111-0.e64ff9.fc29.13.x86_64 : Development files for Io-language Repo : fedora Matched from: Filename : /usr/include/io/cencode.h > > > * The explicit dependencies are dubious: > > 1) The -devel subpackage does not need the base package, since it is > complete due to headers *and* the static lib. Updated. > > 2) The license file does not need to be duplicated as long as the -devel > package explicitly requires the base package, which also contains the same > license file. It doesn't require the base package now, so I'll leave that in here. > > > * Package %summary and %description are not clear yet IMO. The base package > describes a library. Yet it only contains an executable. Is this better, do you think? "Tool for fast encoding/decoding data into and from a base64-encoded format" > The %description > continues with a very brief comment on "Base64" without telling what > functionality is provided by this package. This is all upstream says: "libb64 is a library of ANSI C routines for fast encoding/decoding data into and from a base64-encoded format. C++ wrappers are included, as well as the source code for standalone encoding and decoding executables. " I've now copied bits from wikipedia too. How is this? "Base64 is a group of similar binary-to-text encoding schemes that represent binary data in an ASCII string format by translating it into a radix-64 representation. The term Base64 originates from a specific MIME content transfer encoding. Each Base64 digit represents exactly 6 bits of data. Three 8-bit bytes (i.e., a total of 24 bits) can therefore be represented by four 6-bit Base64 digits. Base64 uses a subset of displayable ASCII characters, and is therefore a useful encoding for storing binary data in a text file, such as XML, or sending binary data over text-only email. libb64 is a library of ANSI C routines for fast encoding/decoding data into and from a base64-encoded format. C++ wrappers are included, as well as the source code for standalone encoding and decoding executables. " > > > > https://kojipkgs.fedoraproject.org//work/tasks/6540/30656540/build.log > > https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags Can you please be more clear on what I'm missing here? Is it the addition of -O3 to the flags? I've corrected that bit now, but you'll have to point out what else I'm missing, I'm afraid. Updated spec/srpm: https://ankursinha.fedorapeople.org/libb64/libb64.spec https://ankursinha.fedorapeople.org/libb64/libb64-1.2-3.fc29.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30684654 Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
