https://bugzilla.redhat.com/show_bug.cgi?id=1515053 --- Comment #10 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Elliott Sales de Andrade from comment #9) > (In reply to Ankur Sinha (FranciscoD) from comment #8) <snip> > > > There are a few bundling issues here: > > > > - I'm not sure whether the various JS libraries that you're including can be > > bundled. The guidelines here say they must be packaged separately too: > > > > https://fedoraproject.org/wiki/JavaScript_libraries_packaging_guideline_draft > > Unfortunately, the JS ecosystem never really seemed to have taken off as far > as packages go... As you can see that guideline has been a draft for 10 > years. Yes, I understand that, but it still is bundling. Maybe it'll be worth quickly checking up on the devel list to see how this should be handled? > > > - extern/asizeof is part of Pympler which is in Fedora. So that should be > > used > > instead of the bundled copy: > > https://src.fedoraproject.org/rpms/python-Pympler > > It's a bundled library in pympler too. Ugh. This shouldn't be, but I reckon it's too tiny a module to call it "bundling", even though it is. > > > - extern/json-minify is bundled too. I expect this needs to be packaged > > separately also as I've not been able to find it in the repos: > > https://pypi.org/project/JSON_minify/ > > I think the package never existed before, so I will see if I can unbundle it > upstream. +1 Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
