https://bugzilla.redhat.com/show_bug.cgi?id=1645172 --- Comment #3 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- - please wordwrap comments to 80 columns at max - please use %make_build instead of 'make' - if possible do not use %attr for normal modes like 755, fix the modes of installed files instead - list all buildrequires like gcc, make, etc., it's wrong to make any assumptions about packages pre-installed in the buildroot - do not redefine %url macro, just use 'URL:' before the 'Source0:' Also note: if you need to define macros, please used '%global' instead of '%define' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
