https://bugzilla.redhat.com/show_bug.cgi?id=1643924 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source archive (SHA-256: c977d7e5424a3ce3cf28509b93422cb9df2872faaa3225afbe470537a0747bd9) is original. Ok. Summary verified from lib/Graphics/ColorNames/HTML.pm. Ok. Description verified from lib/Graphics/ColorNames/HTML.pm. Ok. License verified from lib/Graphics/ColorNames/HTML.pm, LICENSE, and README.md. Ok. No XS code, noarch BuildArch is Ok. CPAN::Meta and CPAN::Meta::Prereqs build-dependencies are not helpful. Ok. Test::CleanNamespaces, Test::EOL, Test::Fixme, Test::NoTabs, Test::Perl::Critic, Test::Pod are not used. Ok. TODO: Unset AUTHOR_TESTING and RELEASE_TESTING environment variables before executing "make test" to be sure the tests won't fail on a missing dependencies. FIX: Do not build-require perl(Graphics::ColorNames)? It's nowhere used. All tests pass. Ok. $ rpmlint perl-Graphics-ColorNames-HTML.spec ../SRPMS/perl-Graphics-ColorNames-HTML-3.3.1-1.fc30.src.rpm ../RPMS/noarch/perl-Graphics-ColorNames-HTML-3.3.1-1.fc30.noarch.rpm sh: /usr/bin/python: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Graphics-ColorNames-HTML-3.3.1-1.fc30.noarch.rpm drwxr-xr-x 2 root root 0 Oct 30 13:49 /usr/share/doc/perl-Graphics-ColorNames-HTML -rw-r--r-- 1 root root 287 Oct 21 18:08 /usr/share/doc/perl-Graphics-ColorNames-HTML/Changes -rw-r--r-- 1 root root 1877 Oct 21 18:08 /usr/share/doc/perl-Graphics-ColorNames-HTML/README.md drwxr-xr-x 2 root root 0 Oct 30 13:49 /usr/share/licenses/perl-Graphics-ColorNames-HTML -rw-r--r-- 1 root root 7431 Oct 21 18:08 /usr/share/licenses/perl-Graphics-ColorNames-HTML/LICENSE -rw-r--r-- 1 root root 1950 Oct 30 13:49 /usr/share/man/man3/Graphics::ColorNames::HTML.3pm.gz drwxr-xr-x 2 root root 0 Oct 30 13:49 /usr/share/perl5/vendor_perl/Graphics drwxr-xr-x 2 root root 0 Oct 30 13:49 /usr/share/perl5/vendor_perl/Graphics/ColorNames -rw-r--r-- 1 root root 2557 Oct 21 18:08 /usr/share/perl5/vendor_perl/Graphics/ColorNames/HTML.pm File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Graphics-ColorNames-HTML-3.3.1-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.0) 1 perl(:VERSION) >= 5.6.0 1 perl(Graphics::ColorNames) 1 perl(integer) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: What's the point in hard-requiring perl(Graphics::ColorNames)? Either use Recommends as recommended by the upstream (META.json:44) or Suggests or remove it completely because sole installation of the module does brings any benefit (it's not optionally used from perl-Graphics-ColorNames-HTML code at all). $ rpm -q --provides -p ../RPMS/noarch/perl-Graphics-ColorNames-HTML-3.3.1-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(Graphics::ColorNames::HTML) = 3.3.1 1 perl-Graphics-ColorNames-HTML = 3.3.1-1.fc30 Binary provides are Ok. The package builds in F30 (https://koji.fedoraproject.org/koji/taskinfo?taskID=30558051). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' item and consider fixing `TODO' items before building this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
