https://bugzilla.redhat.com/show_bug.cgi?id=1643764 Henrik Boeving <hargonix@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hargonix@xxxxxxxxx --- Comment #1 from Henrik Boeving <hargonix@xxxxxxxxx> --- Doing a non official review A few things i noticed: 1. The Fedora packaging guidelines say that "the source package for a Python library MUST be named with the python- prefix." 2. Not a must have but as the library appears to be available on PyPi you could replace your Source0 line with Source0: %pypi_source 3. The intelhex/bench.py and the files in /scripts file use /usr/bin/python which isn't allowed according to the guidelines. You can fix that in %build by using sed -i '1{/^#!\//d}' /path/to/file.py 4. You might want to correct the spelling mistake of Manual you made in your Summary in line 42. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
