https://bugzilla.redhat.com/show_bug.cgi?id=1643266 --- Comment #11 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Thanks for the review. (In reply to Miro Hrončok from comment #10) > (In reply to Ankur Sinha (FranciscoD) from comment #8) > > (I've used bcond temporarily for your convenience. I'll remove it before > > pushing to SCM.) > > The suggestion was for you. If you don't want it, don't put it there just > for me ;) Oh, I'm one of those people that abuse koji for this. I rarely run a local mock build on my system here. :) > > Package Review > ============== > > Issues: > > * I believe the license should be BSD, not MIT. Yes, corrected. > * There are stray unneeded shebangs, remove them (see rpmlint output). Corrected too (and queried upstream: https://github.com/NeuralEnsemble/libNeuroML/issues/77) > * Other rpmlint warnings (wrong-file-end-of-line-encoding, > hidden-file-or-dir) > Corrected. While I was at it, I also added missing Requires to the spec after looking at the source files. The source's requirements and setup.py files do not specify the complete set. Now rpmlint says: $ ls python3-libNeuroML-0.2.45-4.fc30.noarch.rpm python-libNeuroML-0.2.45-4.fc30.src.rpm python-libNeuroML-doc-0.2.45-4.fc30.noarch.rpm $ rpmlint *rpm python3-libNeuroML.noarch: W: spelling-error %description -l en_US morphologies -> morphological, morphology python-libNeuroML.src: W: spelling-error %description -l en_US morphologies -> morphological, morphology python-libNeuroML-doc.noarch: W: spelling-error %description -l en_US morphologies -> morphological, morphology 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Corrected requires are now: == python3-libNeuroML-0.2.45-4.fc30.noarch.rpm == Provides: python3-libNeuroML = 0.2.45-4.fc30 python3.7dist(libneuroml) = 0.2.45 python3dist(libneuroml) = 0.2.45 Requires: python(abi) = 3.7 python3dist(jsonpickle) python3dist(lxml) python3dist(numpy) python3dist(pymongo) python3dist(tables) == python-libNeuroML-0.2.45-4.fc30.src.rpm == Provides: Requires: python3-devel python3dist(jsonpickle) python3dist(lxml) python3dist(nose) python3dist(numpy) python3dist(pymongo) python3dist(sphinx) python3dist(tables) == python-libNeuroML-doc-0.2.45-4.fc30.noarch.rpm == Provides: python-libNeuroML-doc = 0.2.45-4.fc30 Requires: -- Updated spec/srpm: https://ankursinha.fedorapeople.org/python-libNeuroML/python-libNeuroML.spec https://ankursinha.fedorapeople.org/python-libNeuroML/python-libNeuroML-0.2.45-4.fc29.src.rpm Scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=30472859 Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
