https://bugzilla.redhat.com/show_bug.cgi?id=1636757 Tomas Mraz <tmraz@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #5 from Tomas Mraz <tmraz@xxxxxxxxxx> --- As this is a snapshot from git, the snapshot should be clearly marked in the release. So the name-version-release should actually be: openssl-gost-engine-1.1.0.3-3.20181002git3383ad1.fcxy This will make it clear what snapshot was used. If you later switch to a regular release this can be of course omitted. This is a minor issue that can be fixed later and I approve the package. rpmlint output: gostsum-debuginfo.x86_64: I: checking gostsum-debuginfo.x86_64: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) gostsum-debuginfo.x86_64: E: useless-provides debuginfo(build-id) gostsum.x86_64: I: checking gostsum.x86_64: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) gostsum.x86_64: W: only-non-binary-in-usr-lib openssl-gost-engine-debuginfo.x86_64: I: checking openssl-gost-engine-debuginfo.x86_64: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) openssl-gost-engine-debugsource.x86_64: I: checking openssl-gost-engine-debugsource.x86_64: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) openssl-gost-engine-debugsource.x86_64: W: no-documentation openssl-gost-engine.src: I: checking openssl-gost-engine.src: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) openssl-gost-engine.src: W: invalid-url Source0: engine-1.1.0.3.tar.gz openssl-gost-engine.x86_64: I: checking openssl-gost-engine.x86_64: I: checking-url https://github.com/gost-engine/engine (timeout 10 seconds) 6 packages and 0 specfiles checked; 1 errors, 3 warnings. All the warnings and errors above are OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
