https://bugzilla.redhat.com/show_bug.cgi?id=1641386 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hi and welcome to Fedora. First problem: - Python 2 is deprecated in Fedora 30, would it be possible to build it with Python 3 instead? Otherwise this package won't be accepted as is. We don't accept anything Python 2 related anymore. Your SPEC is rot really in line with the Guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/ I will go over the issues: - Group is not used in Fedora, neither is Buildroot: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections - Please add a comment for each patch explaining why they are needed: Patch0: not_null_argument_for_strcmp.patch Patch1: werror.patch - AGPL-3.0 is not a valid shorthand. See the list here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses License: AGPLv3 - Release is missing its dist tag: Release: 1%{?dist} - %setup -q -n %{name}-%{version} %patch0 -p1 %patch1 -p1 You could use %autosetup -p1 - make -C src → %make_build Although, reading the Makefile, I wonder if it would not be better to do pushd src/ %py2_build popd That way it would respect Fedora build flags. - The install location is wrong, it should use %{_libdir}: mkdir -p %{buildroot}/%{_libdir}/security And: %{_libdir}/security/pam_python.so - make -C src install LIBDIR=%{buildroot}/%{_lib}/security → %make_install -C src LIBDIR=%{_libdir}/security - Not needed: %defattr(-,root,root) - The license must be installed with %license, not %doc %license agpl-3.0.txt - Add the examples in %doc %doc examples - Build the doc/ with Sphinx and add them to %doc %doc doc/html - Add your %changelog entry %changelog * Tue Oct 23 2018 Alexander Naumov <posix.ru@xxxxxxxxx> - 1.0.6-1 - Initial release - Source0 is 404. It should be: Source: https://sourceforge.net/projects/%{name}/files/%{name}-%{version}-1/%{name}-%{version}.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
