https://bugzilla.redhat.com/show_bug.cgi?id=1641203 --- Comment #12 from Shlomi Fish <shlomif@xxxxxxxxxxxxxx> --- (In reply to Shlomi Fish from comment #11) > Hi, > > (In reply to Neal Gompa from comment #10) > > > %{_bindir}/fc_solve_find_index_s2ints.py > > > %{_bindir}/find-freecell-deal-index.py > > > %{_bindir}/make_pysol_freecell_board.py > > > %{_bindir}/transpose-freecell-board.py > > > > Why are these files suffixed with .py instead of just being binary names? If > > they're executables people should run, they probably shouldn't be suffixed > > with .py. If they are not, then they probably need to go elsewhere. > > > > well, %{_bindir}/fc_solve_find_index_s2ints.py is a module and can be moved > under /usr/lib/python . The others are suffixed like this due to my > program's back compat policy and possible win32/win64 compatibility. > > > Also, shouldn't the main package have a "Requires: %{libname}%{?_isa} = > > %{version}-%{release}" too, since it uses the library? > > I can add it. SRPM and .spec updated and are rpmlint, dnf and mock clean. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
