[Bug 1638980] Review Request: gsrp5-webserver - Global system resource plаnnig web client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1638980

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx
             Blocks|                            |177841 (FE-NEEDSPONSOR)



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Use %global, not %define

 - Source0: must be a URL pointing to the upstream archive

 - Group: BuildRoot: Prefix: Vendor: Packager: must not be used in Fedora

 - Not needed:

%clean
rm -rf $RPM_BUILD_ROOT

 - env CFLAGS="$RPM_OPT_FLAGS" python3 setup.py build → %py3_build

 - python3 setup.py install -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES
→ %py3_install

 - Not needed:

%defattr(-,root,root)

 - You need to include a %changelog

 - http://www.gsrp.org/ is 404

 - AGPL-3 is not a valid license shorthand, it should be AGPLv3

 - You're missing the BuildRequires for a python package


Read the guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/

and https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux