https://bugzilla.redhat.com/show_bug.cgi?id=1612092 --- Comment #7 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to Iñaki Ucar from comment #1) > This is an informal review. Some comments: > > - Source -> you can use %pypi_source > https://fedoraproject.org/wiki/Packaging:Python#Source_Files_from_PyPI > This is fine to not do, especially since this needs to be EPEL compatible. > - Why does build require git? > Aurelien, did you intend to use Git to apply patches? If so, you should switch from %setup and %patch invocations to %autosetup -n %{pypi_name}-%{version} -S git > - A brief comment on what the patches do, apart from the reference URLs, is > advisable > > - You can use %{py3_dist} to resolve to standardized names > https://fedoraproject.org/wiki/Packaging: > Python#Requires_and_BuildRequires_with_standardized_names > The standardized names don't work in EPEL. A better alternative would be to use the dependency generator on Fedora, and manually specify only for EPEL. An example of an EPEL compatible way to set that up is here: https://src.fedoraproject.org/rpms/pagure/blob/master/f/pagure.spec > - You can use %{?systemd_requires} as a shortcut for listing the > per-scriptlet dependencies on systemd > https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd > > - There is a %{_unitdir} macro for systemd service files > https://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations > Please use this. > - %setup, %patch -> %autosetup applies patches automatically > https://fedoraproject.org/wiki/Packaging:Guidelines#Applying_patches > As noted above, you may want to consider "%autosetup -n %{pypi_name}-%{version} -S git" > - %{__python3} setup.py build -> %py3_build, %{__python3} setup.py install > -> %py3_install > https://fedoraproject.org/wiki/Packaging:Python#Macros > Please do this. > - Not needed: rm -rf %{buildroot} > https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections > Please fix this. > - rm -rf src/%{pypi_name}.egg-info -> the egg-info is not binary and must be > included > https://fedoraproject.org/wiki/Packaging:Python#Files_to_include > Please fix this. > - Packages with cron job files must have an explicit Requires: crontabs > https://fedoraproject.org/wiki/Packaging:CronFiles Why are we using cron jobs instead of systemd timers? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
