[Bug 1638968] Review Request: libneurosim - Common interfaces for neuronal simulators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1638968



--- Comment #6 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
(In reply to Antonio Trande from comment #3)
> I made some changes to the SPEC file:
> 
> Compiler/linker flags are automatically set now; MPI compilers are now used.

Thanks---one doesn't need to export CC etc---the configure script picks those
up and does it correctly (I've double checked the logs)

> 
> Paths for Python MPI libraries are not those used, they should be
> $MPI_PYTHON2_SITEARCH and $MPI_PYTHON2_SITEARCH.

These are also set by the macros used to load mpi modules:

++ MPI_BIN=/usr/lib64/mpich/bin
++ export MPI_BIN
++ MPI_COMPILER=mpich-x86_64
++ export MPI_COMPILER
++ MPI_FORTRAN_MOD_DIR=/usr/lib64/gfortran/modules/mpich
++ export MPI_FORTRAN_MOD_DIR
++ MPI_HOME=/usr/lib64/mpich
++ export MPI_HOME
++ MPI_INCLUDE=/usr/include/mpich-x86_64
++ export MPI_INCLUDE
++ MPI_LIB=/usr/lib64/mpich/lib
++ export MPI_LIB
++ MPI_MAN=/usr/share/man/mpich-x86_64
++ export MPI_MAN
++ MPI_PYTHON2_SITEARCH=/usr/lib64/python2.7/site-packages/mpich
++ export MPI_PYTHON2_SITEARCH
++ MPI_PYTHON3_SITEARCH=/usr/lib64/python3.7/site-packages/mpich
++ export MPI_PYTHON3_SITEARCH
++ MPI_PYTHON_SITEARCH=/usr/lib64/python2.7/site-packages/mpich
++ export MPI_PYTHON_SITEARCH
++ MPI_SUFFIX=_mpich
++ export MPI_SUFFIX
++ MPI_SYSCONFIG=/etc/mpich-x86_64

> 
> About debuginfo packages, all libraries look not stripped when are compiled.
> I left the '%global debug_package %{nil}' line, you need to ask to upstream
> for studying what's happing.

I've fixed this now. 

> 
> Where are the '%{name}-openmpi(mpich)-common = %{version}-%{release}'
> packages?

Ah, yes---I added a "common" subpackage as Rathann suggested. Had forgotten
those. We don't need separate ones for the two mpi variants here, fortunately.


> 
> https://paste.fedoraproject.org/paste/GM1v~C6Y9MasgIPqH9i9AA


Updated spec/srpm:

https://ankursinha.fedorapeople.org/libneurosim/libneurosim-0-0.201810190941.git57b76e2.fc29.src.rpm

https://ankursinha.fedorapeople.org/libneurosim/libneurosim.spec

Thanks,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux