https://bugzilla.redhat.com/show_bug.cgi?id=1638431 Georg Sauthoff <fedora@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxx --- Comment #2 from Georg Sauthoff <fedora@xxxxxxxx> --- Just a few comments: - Your `Release: 0` tag violates the versioning guidelines: https://fedoraproject.org/wiki/Packaging:Versioning#Simple_versioning i.e. you have to start with 1%{?dist} - Since the package is also available on PyPI it makes sense to use that as source, i.e. this simplifies your Source line like this (and makes it easier to maintain): Source0: %pypi_source - Your package name violates the current naming policy: https://fedoraproject.org/wiki/Packaging:Python#Naming i.e. you can rename the spec file to python-getmac and define a python3-getmac subpackage therein - AFAICT the rpm changelog is primarily for changes to your spec file - since the spec file actually exists, i.e. your spec file should just include one entry right now, i.e. something like: * Sat Oct 13 2018 Henrik Boeving <mail@xxxxxxxxxxx> - 0.6.0-1 - initial packaging -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
