https://bugzilla.redhat.com/show_bug.cgi?id=1638824 --- Comment #4 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Luis Segundo from comment #1) > you need to make some changes > > Issues: > ======= > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: gcc-c++ > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 It's a false positive. 'gcc-c++' must be listed as BuildRequires package else compiler is not installed. (In reply to Luis Segundo from comment #3) > Hi Casper, > > For documentation use the macro: %doc > and this one "%{_datarootdir}" can be removed > > > for License replace > %license %{_datarootdir}/doc/KDSoap/LICENSE.txt > %license %{_datarootdir}/doc/KDSoap/LICENSE.GPL.txt > %license %{_datarootdir}/doc/KDSoap/LICENSE.US.txt > > to %doc doc/KDSoap/LICENSE* 'doc/KDSoap/' is the wrong place for installing license files. Casper needs to remove all LICENSE* files inside 'doc/KDSoap/', mark them with the '%license' macro and comment for indicate which files are licensed with a specific license. See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
