https://bugzilla.redhat.com/show_bug.cgi?id=1554022 --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Sorry to have forgotten you. - Please space out your changelog entry, they are difficult to read - I would rather have you not mix Suse stuff with Fedora stuff. - Install the license file with %license, not %doc %doc README %license COPYING - Your %changelog entry must contain the release-version: * Sat Mar 10 2018 stefan.koch10@xxxxxxxxx - 1.0-1 - Add a BR for gcc - Split the description to stay below 80 characters - Use %autosetup or %setup -q to make the setup quiet: - Use %find_lang in %install to install the translations: %install %make_install %find_lang %name %files -f %name.lang Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2)", "Unknown or generated". 14 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review /usbauth-notifier/review-usbauth-notifier/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/xdg/autostart(filesystem) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-build See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in usbauth- notifier-debuginfo , usbauth-notifier-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: usbauth-notifier-1.0-1.fc30.x86_64.rpm usbauth-notifier-debuginfo-1.0-1.fc30.x86_64.rpm usbauth-notifier-debugsource-1.0-1.fc30.x86_64.rpm usbauth-notifier-1.0-1.fc30.src.rpm usbauth-notifier.x86_64: E: description-line-too-long C A notifier for the usbauth firewall against BadUSB attacks. The user could manually allow or deny USB devices. usbauth-notifier.x86_64: W: incoherent-version-in-changelog tefan.koch10@xxxxxxxxx ['1.0-1.fc30', '1.0-1'] usbauth-notifier.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/usbauth-notifier.desktop usbauth-notifier.x86_64: W: non-standard-gid /usr/bin/usbauth-npriv usbauth usbauth-notifier.x86_64: E: setuid-binary /usr/bin/usbauth-npriv root 4750 usbauth-notifier.x86_64: E: non-standard-executable-perm /usr/bin/usbauth-npriv 4750 usbauth-notifier.x86_64: E: non-standard-executable-perm /usr/bin/usbauth-npriv 4750 usbauth-notifier.x86_64: W: non-standard-gid /usr/lib/usbauth-notifier usbauth-notifier usbauth-notifier.x86_64: E: non-standard-dir-perm /usr/lib/usbauth-notifier 750 usbauth-notifier.x86_64: W: non-standard-gid /usr/lib/usbauth-notifier/usbauth-notifier usbauth usbauth-notifier.x86_64: E: setgid-binary /usr/lib/usbauth-notifier/usbauth-notifier usbauth 2755 usbauth-notifier.x86_64: E: non-standard-executable-perm /usr/lib/usbauth-notifier/usbauth-notifier 2755 usbauth-notifier.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/usbauth-notifier.mo usbauth-notifier.x86_64: W: file-not-in-%lang /usr/share/locale/zh_TW/LC_MESSAGES/usbauth-notifier.mo usbauth-notifier.src: E: description-line-too-long C A notifier for the usbauth firewall against BadUSB attacks. The user could manually allow or deny USB devices. usbauth-notifier.src:64: W: setup-not-quiet usbauth-notifier.src: W: invalid-url Source0: usbauth-notifier-1.0.tar.bz2 4 packages and 0 specfiles checked; 8 errors, 9 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
