https://bugzilla.redhat.com/show_bug.cgi?id=1611598 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - %{__python} setup.py build → %py3_build - %{__python} setup.py install --single-version-externally-managed -O1 --root=$RPM_BUILD_ROOT → %py3_install - Source0 must point to a URL - Package must be Python3, you mist not require python-X package as this is deprecated. Python 2 is also deprecated. - If you install systemd files you must require: %{?systemd_requires} BuildRequires: systemd - Keep timestamps with install-p - These permissions are not standard, please provide rationale. It should be 0644 %attr(0655, root, root) %{_sysconfdir}/collectd_template/* %attr(0655, root, root) %{_libdir}/collectd/* - Add your own %changelog entry -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
