[Bug 1562526] Review Request: libfullock - A Fast User Level LOCK (FULLOCK ) library for C and C++

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1562526



--- Comment #19 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
libfullock.x86_64: W: incoherent-version-in-changelog 1.0.27 ['1.0.27-1.fc27',
'1.0.27-1']

 → You need to add the release info in the %changelog too:

* Tue May 15 2018 Takeshi Nakatani <ggtakec@xxxxxxxxx>   1.0.27-1

   Also add your own %changelog entry with your name in it.

 - Bump to 1.0.28

 - libfullock.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/libfullock.so

This is not ok. Read
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

    Unversioned shared system library files, when a matching versioned shared
system library file is also present. For example, if your package contains:

   /usr/lib/libfoo.so.3.0.0
   /usr/lib/libfoo.so.3
   /usr/lib/libfoo.so

The versioned shared library files (/usr/lib/libfoo.so.3.2.0 and
/usr/lib/libfoo.so.3) are necessary for users to run programs linked against
libfoo, so they belong in the base package. The other, unversioned, shared
library file (/usr/lib/libfoo.so) is only used to actually link libfoo to code
being compiled, and is not necessary to be installed on a users system. This
means that it belongs in a -devel package.


Thas means libfullock.so should be in the devel package:

%files devel
%license COPYING
%if 0%{?rhel} == 6
%defattr(-,root,root)
%endif
%doc README AUTHORS ChangeLog
%{_includedir}/*
%{_libdir}/libfullock.so
%{_libdir}/pkgconfig/*.pc

   And then the main package should not have it.

 - Speaking of which, globbing the major soname version is now forbidden to
avoid unintentional soname bump. So be more specific instead:

%files
%license COPYING
%if 0%{?rhel} == 6
%defattr(-,root,root)
%endif
%doc README AUTHORS ChangeLog
%{_libdir}/libfullock.so.1*
%{_mandir}/man3/*

 - You don't need to reinclude the license in devel because it depends on the
main package which already has it:

%files devel
Remove %license COPYING

 - Group: is not used in Fedora

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux