https://bugzilla.redhat.com/show_bug.cgi?id=1636019 --- Comment #6 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> --- A couple of observations: Please run rpmlint on specs/RPMs. Please use, "License: GPLv3" Provides look strange: mvn(java:decompiler-agent) mvn(java:decompiler-agent:pom:) mvn(java:java-runtime-decompiler:pom:) mvn(java:runtime-decompiler) mvn(java:runtime-decompiler:pom:) I believe you are in control of the upstream project. I'd suggest to use a better gId (Maven group ID). E.g. me.pmikova:decompiler-agent, etc. You can drop explicit requires. The maven requires generator in Fedora will add those: mvn(com.fifesoft:rsyntaxtextarea) mvn(com.google.code.gson:gson) mvn(com.sun:tools) mvn(org.jboss.byteman:byteman-install) >From the spec file: Requires: java-devel >= 1:1.8.0 Yet, in the script you do this: CLASSPATH=$CLASSPATH:${JAVA_HOME}/lib/tools.jar That path is only present for JDK 8. JDK 11 won't have tools.jar. Has this been considered? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
